libsubprocess: increase output watcher priority #6317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chu11
force-pushed
the
issue6302_priority_watcher
branch
from
f124c7e to
db04615
Compare
|
Let's add MWP here so it makes it into today's release |
chu11
force-pushed
the
issue6302_priority_watcher
branch
from
db04615 to
7523530
Compare
Problem: If a output buffer is full, we issue an emergency call to the user's output callback to empty the buffer before more data is put in it. This is done because we cannot control the order in which check callbacks are called. Now that check callbacks can have priority set, we can ensure output check callbacks are called first before a check callback that may put more data in the buffer. Set the priority of the output check watcher higher than the default. Remove the now unnecessary emergency callback to the user's output callback. Fixes flux-framework#6302
chu11
force-pushed
the
issue6302_priority_watcher
branch
from
7523530 to
a7f99af
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6317 +/- ##
==========================================
- Coverage 83.33% 83.33% -0.01%
==========================================
Files 523 523
Lines 86167 86166 -1
==========================================
- Hits 71808 71804 -4
- Misses 14359 14362 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: If a output buffer is full, we issue an emergency call to the user's output callback to empty the buffer before more data is put in it. This is done because we cannot control the order in which check callbacks are called. Now that check callbacks can have priority set, we can ensure output check callbacks are called first before a check callback that may put more data in the buffer.
Set the priority of the output check watcher higher than the default. Remove the now unnecessary emergency callback to the user's output callback.
built on top of #6316